Provide a more helpful error message on spawn() failures #34
Conversation
Make a good-faith effort to catch the `RuntimeError` thrown when improperly invoking the YumFinder on non-Linux platforms, and present a useful error message to the user. Drive-by: update `tox.ini` to work with 4.x Fixes: Issue #31
soufi/finders/yum.py
Outdated
| soufi.finder.factory(*args, **kwargs).find() | ||
|
|
||
| Aborting.""" | ||
| ) |
There was a problem hiding this comment.
Since this seems to be limited to Macs, I'd be more inclined to add a sys.platform check somewhere, as this could could potentially spit out this error incorrectly if another different RuntimeError occurs.
There was a problem hiding this comment.
Also please consider using dedent so we can indent the error string :)
There was a problem hiding this comment.
The behavior will surface on any platform that uses spawn instead of fork in its multiprocessing module, which today means Windows and Mac, and could mean other platforms in the future.
But multiprocessing is prone to throw RuntimeErrors for lots of reasons, so a good-faith check that it's whinging about this particular problem is not unreasonable.
And I suppose calling textwrap.dedent is similarly not too much to ask for 😆
| if 'not using fork' in str(e): | ||
| sys.exit( | ||
| textwrap.dedent( | ||
| """ |
There was a problem hiding this comment.
Just FYI I would accept and prefer this:
textwrap.dedent("""\
wibble
blobble
""")
But no biggie.
There was a problem hiding this comment.
Oh, is that how you get Black to leave that alone? TIL...
There was a problem hiding this comment.
Well it's how I've traditionally done it but who knows with Black these days...
Make a good-faith effort to catch the
RuntimeErrorthrown when improperly invoking the YumFinder on non-Linux platforms, and present a useful error message to the user.Fixes: Issue #31
This change is