Refactor the YumFinder #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement our own XML fetch/parse routines for consuming repomd data, and create a simple lookup dict from the results rather than trying to shoehorn in use of the `repomd.findall` library call. This yields a 30%-50% speedup in the functional tests.
BEFOREAFTER |
Stepping through the refactored workflow showed that the YumFinder was deep-copying a dict into a subprocess, looking up a value, and returning the result. Surely, there must be a better way.
0xDEC0DE
commented
Sep 6, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @juledwar)
juledwar
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Looks great!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement our own XML fetch/parse routines for consuming repomd data, and create a simple lookup dict from the results rather than trying to shoehorn in use of the
repomd.findalllibrary call.This yields a 30%-50% speedup in the functional tests.
This change is