Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PHP PECL finder #61

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add a PHP PECL finder #61

merged 1 commit into from
Oct 9, 2024

Conversation

juledwar
Copy link
Owner

@juledwar juledwar commented Oct 8, 2024

Searches the index at pecl.php.net for the requested package.

Drive-by changes:

  • Add testing on Python 3.12
  • Ensure the local hatch env uses the -cli requirements
  • Fix the README

This change is Reviewable

@juledwar juledwar requested a review from 0xDEC0DE October 8, 2024 06:45
0xDEC0DE
0xDEC0DE previously approved these changes Oct 8, 2024
Copy link
Collaborator

@0xDEC0DE 0xDEC0DE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upside of obsolete technology is that it's delightfully simple :trollface:

soufi/cli.py Outdated
@@ -295,8 +306,8 @@ def main(
archive is used instead.

The sources currently supported are 'debian', 'ubuntu', 'rhel', 'centos',
'alpine', 'photon', 'java', 'go', 'python', and 'npm', one of which must be
specified as the DISTRO argument.
'alpine', 'photon', 'java', 'go', 'python', 'create', 'phppecl, and 'npm',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a '. I'll leave it to you to figure out where :trollface:

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FFS!

Searches the index at pecl.php.net for the requested package.

Drive-by changes:
 - Add testing on Python 3.12
 - Ensure the local hatch env uses the -cli requirements
 - Fix the README
@juledwar juledwar merged commit cfe7107 into master Oct 9, 2024
10 checks passed
@juledwar juledwar deleted the php-pecl-finder branch October 9, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants