Merge pull request #951 from julep-ai/x/github-action

fix: bug fixs for github action generate changelog
julep-ai · Dec 12, 2024 · 6b3aa25 · 6b3aa25
2 parents 537a134 + 4ba5a7e
commit 6b3aa25
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/generate-changelog.yml b/.github/workflows/generate-changelog.yml
@@ -1,7 +1,8 @@
-name: Julep-Changelog-Generation
+name: Julep Changelog Generation
+run-name: ${{ github.actor }} is generating changelog for the last two weeks using Julep
 
 on:
-  workflow_dispatch: {}
+  workflow_dispatch:
 
 jobs:
   changelog_generation:
@@ -43,7 +44,7 @@ jobs:
           fi
 
           echo "pr_data=$merged_prs" >> $GITHUB_ENV
-          echo "{\"pr_data\": $merged_prs}" > pr_data.json
+          echo "$merged_prs" > pr_data.json
 
       - name: Setup Python v3.10.12
         uses: actions/setup-python@v5

diff --git a/scripts/generate_changelog.py b/scripts/generate_changelog.py
@@ -182,7 +182,7 @@ def main(pr_data: str) -> None:
     try:
         # Read PR data from JSON file
         with open('pr_data.json', 'r') as file:
-            pr_data = json.load(file)
+            pr_data = file.read()
         main(pr_data)
     except Exception as e:
         logging.error(f"Script failed: {str(e)}")