fix paths of symbols in stdlibs #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
commented
Jul 24, 2020
Comment on lines
+6
to
+21
| InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240" | ||
| LibGit2 = "76f85450-5226-5b5a-8eaa-529ad045b433" | ||
| Markdown = "d6f4376e-aef5-505a-96c1-9c027394607a" | ||
| Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f" | ||
| REPL = "3fa0cd96-eef1-5676-8a61-b3b8758bbffb" | ||
| SHA = "ea8e919c-243c-51af-8825-aaa63cd721ce" | ||
| Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b" | ||
| Sockets = "6462fe0b-24de-5631-8697-dd941f90decc" | ||
| UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4" | ||
| Markdown = "d6f4376e-aef5-505a-96c1-9c027394607a" | ||
|
|
||
| [extras] | ||
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
|
||
| [compat] | ||
| julia = "1" | ||
|
|
||
| [extras] | ||
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
|
There was a problem hiding this comment.
I remember we discussed this before, but can't we live with these automatic formattings by Pkg.jl ? I want to add packages via Pkg.jl's interface (which automatically involves these sorting formatting)
There was a problem hiding this comment.
We should add commands to the extension that make it easier to manage the Project.toml :) Lets see what happens if I next tag things, whether the tagging infrastructure changes the formatting back to something else.
ZacLN
approved these changes
Jul 24, 2020
|
@aviatesk yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the locations of symbols in standard library are invalid for julia that is not built from source. E.g.
LinearAlgebra.eigen's location would be/Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.4/InteractiveUtils/src/InteractiveUtils.jl:53on macOS.This is because of JuliaLang/julia#26314 and I'm trying to fix this borrowing the code in CodeTracking.jl to fix this issue.
@ZacLN is my understanding correct that SymbolServer only collects locations of methods, right ? Otherwise we need to use this kind of patching for other places as well.