Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish translation #108

Closed
wants to merge 9 commits into from
Closed

Polish translation #108

wants to merge 9 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2017

Hello, I made a Polish translation. On the first try I learned how to create a folder and file on GitHub, the final result is a complete translation into my native language. The first six commits were for learning.
Regards.

@ghost ghost changed the title Polish translation test Apr 13, 2017
@ghost ghost changed the title test Polish translation Apr 13, 2017
@ghost
Copy link
Author

ghost commented Apr 13, 2017

I don't know why this didn't pass a checks. I copied everything from English original file and I changed only letters from English to Polish, I didn't change the code.

Any suggestions?

/home/travis/build/julian-klode/dns66/app/build/intermediates/res/merged/release/values-pl/values-pl.xml:36: warning: string 'app_name' marked untranslatable but exists in locale 'pl'

/home/travis/build/julian-klode/dns66/app/build/intermediates/res/merged/release/values-pl/values-pl.xml:59: warning: string 'info_app_copyright' marked untranslatable but exists in locale 'pl'

/home/travis/build/julian-klode/dns66/app/build/intermediates/res/merged/release/values-pl/values-pl.xml:92: warning: string 'website' marked untranslatable but exists in locale 'pl'

@julian-klode
Copy link
Owner

Hi! The problem is that you are trying to translate untranslatable strings. As the name implies, that can't work, and you'd have to remove these lines.

Maybe I should use some online translation service where people can just sign up and translate strings in a friendly web interface, like crowdin. But that ends up with a lot of commits or loss of attribution in the commits, which is not that nice.

UI is currently a bit in a flux, with some new strings coming in in the next days, so it's probably best to wait until that is ready and then you can have a fully translated 0.5 release :)

@julian-klode
Copy link
Owner

Sorry, accidental close.

@julian-klode julian-klode reopened this Apr 14, 2017
@julian-klode
Copy link
Owner

julian-klode commented Apr 19, 2017

@justmix4 Strings are frozen now for the 0.5 release, so it would be great if you could rebase your work against the current master branch (there are quite a lot of new features needing translation).

@julian-klode julian-klode added this to the 0.5 milestone Apr 20, 2017
@julian-klode julian-klode modified the milestones: 0.5.1, 0.5 Apr 21, 2017
@ghost
Copy link
Author

ghost commented May 11, 2017

Hi Julian. Translation is finally improved and ready for use. Regards!

@codecov-io
Copy link

Codecov Report

Merging #108 into master will increase coverage by 7.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   20.09%   27.35%   +7.25%     
==========================================
  Files          21       25       +4     
  Lines        1483     1733     +250     
  Branches      167      208      +41     
==========================================
+ Hits          298      474     +176     
- Misses       1173     1242      +69     
- Partials       12       17       +5
Impacted Files Coverage Δ
...org/jak_linux/dns66/db/RuleDatabaseUpdateTask.java 24.39% <0%> (-1.59%) ⬇️
.../jak_linux/dns66/main/ItemTouchHelperCallback.java 0% <0%> (ø) ⬆️
...rc/main/java/org/jak_linux/dns66/MainActivity.java 0% <0%> (ø) ⬆️
...n/java/org/jak_linux/dns66/main/HostsFragment.java 0% <0%> (ø) ⬆️
...n/java/org/jak_linux/dns66/main/StartFragment.java 0% <0%> (ø) ⬆️
...jak_linux/dns66/main/MainFragmentPagerAdapter.java 0% <0%> (ø) ⬆️
...va/org/jak_linux/dns66/main/WhitelistFragment.java 0% <0%> (ø) ⬆️
...ain/java/org/jak_linux/dns66/main/DNSFragment.java 0% <0%> (ø) ⬆️
.../jak_linux/dns66/main/ItemRecyclerViewAdapter.java 0% <0%> (ø) ⬆️
...rc/main/java/org/jak_linux/dns66/ItemActivity.java 0% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872996c...d38cdce. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants