Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to selectively whitelist apps #44

Merged
merged 2 commits into from
Dec 13, 2016
Merged

Add ability to selectively whitelist apps #44

merged 2 commits into from
Dec 13, 2016

Conversation

farmerbb
Copy link
Contributor

@farmerbb farmerbb commented Dec 1, 2016

This adds an option in the overflow menu for the user to select individual apps to whitelist from the VPN, so that more apps can work around issue #31.

(One caveat: this will require the user to reset settings to default, otherwise, the VPN will not start successfully)

@julian-klode
Copy link
Owner

Sounds nice. We still have to make sure that the VPN can start successfully without a reset to defaults, though - there should be some migration (that's why I included version numbers, but this can also be done heuristically by just looking if the field is defined or not, and if not, loading it from the default).

I have not looked at the code in detail yet, but I hope to get around to it this week. My schedule so far looks quite OK.

@farmerbb
Copy link
Contributor Author

farmerbb commented Dec 7, 2016

Alright, the app whitelist no longer messes with settings.json and should no longer require a settings reset. Let me know if you have any other feedback. I think this will help a lot of users, especially those on Nougat.

@julian-klode julian-klode merged commit ee75f41 into julian-klode:master Dec 13, 2016
julian-klode added a commit that referenced this pull request Dec 13, 2016
Add ability to selectively whitelist apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants