Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animating the Property Offset of an SVG Gradient #229

Closed
sayore opened this issue Sep 8, 2017 · 5 comments
Closed

Animating the Property Offset of an SVG Gradient #229

sayore opened this issue Sep 8, 2017 · 5 comments

Comments

@sayore
Copy link

sayore commented Sep 8, 2017

Well .. as the name 'offset' is taken by the animating properties it seems impossible to me to animate it per the usual way.

@juliangarnier
Copy link
Owner

Yes, that's the downside of having a single object for both animatable properties and settings.
Prior to 2.x there weren't too much "locked" properties.
I might change some of the property names, or change the API style in the future.

Any suggestions are welcome.

@sayore
Copy link
Author

sayore commented Sep 11, 2017

Maybe changing it to this style:

css: { offset: x, height: x,... }
html: { offset: x, height: x,... }

or this one:

css-offset: x,
tag-offset: x / html-offset: x

^ this style doesn't have to be the main way to declare these kind of properties; the current way works pretty dandy. Just as another notation way. Love the way it is.
I got a workaround to get this problem to work now too. (I used an external Object and an event to update the offset per jQuery)

Can't really help with the code though. Never really used Github to make Pull Requests(i suppose thats how you call code submissions right?)

@iconexperience
Copy link

Offset can relate to many dimensions: xOffset, yOffset, timeOffset. So maybe in the next major update renaming offset to timeOffset would be a way to solve this.

@zanetaylor
Copy link

zanetaylor commented Nov 2, 2017

Would it make sense to add a prefix to the property that could also be used consistently across the other settings properties, to prevent other possible name conflicts? Something like animOffset?

@juliangarnier
Copy link
Owner

The offset property has been replaced by timelineOffset in V3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants