-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a callback called cleanup to do additional tasks before removing animations #458
Open
dhwanils95
wants to merge
12
commits into
juliangarnier:master
Choose a base branch
from
dhwanils95:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are cleaned before resetting.
Hey, any update on the status of the pull request? It's been 3 months and I feel this is a very useful feature, a response will be highly appreciated. |
…s are cleaned before resetting.
# Conflicts: # lib/anime.es.js
# Conflicts: # lib/anime.es.js # lib/anime.min.js
Would begin() not do the trick if your problem is setting it back when resetting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have created a new callback called 'cleanup' which can be called with the hook 'cleaner'. What I wanted to achieve is as follows:
I wanted to write an animation where on the complete callback, I change the position to absolute because it's place is taken up by another element. Now, once the animation was completed the position was set to absolute. But on reset, there was no way for me to set the target's position back to a relative which is what I wanted to do. Right now, I am unable to manipulate the position so I had to find a workaround like this. This is not very specific to my need and I feel many people can use a cleaner function to do something before resetting.