Fix getParentSvgEl which returned the wrong item #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoncaloGMarques
approved these changes
May 29, 2019
|
Hey bro people seem to ignore this pull request so I created a fork and published the fixed version on npm it's called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix getParentSvgEl
This PR for fix bug with function
getParentSvgElwhich returned parent of SVG element, but not root SVG element (HTML tag). It's need for responsive animation with "motion path".The solution is simple. We need just replce break condition up for one line before
parentElremains root SVG element.This example to demonstrate the problem: https://codepen.io/spz/pen/MxYywK?editors=1111
This example of resolved problem (with build animejs after fix function): https://codepen.io/spz/pen/zbxqQW?editors=1011