Apply suggestions from code review

Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
julianocosta89 · Dec 13, 2024 · aa1725d · aa1725d
1 parent 1ce5e73
commit aa1725d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/cartservice/src/Program.cs b/src/cartservice/src/Program.cs
@@ -61,15 +61,15 @@
 builder.Services.AddOpenTelemetry()
     .ConfigureResource(appResourceBuilder)
     .WithTracing(tracerBuilder => tracerBuilder
-        .AddSource("OpenTelemetry.Demo.Cart.Source")
+        .AddSource("OpenTelemetry.Demo.Cart")
         .AddRedisInstrumentation(
             options => options.SetVerboseDatabaseStatements = true)
         .AddAspNetCoreInstrumentation()
         .AddGrpcClientInstrumentation()
         .AddHttpClientInstrumentation()
         .AddOtlpExporter())
     .WithMetrics(meterBuilder => meterBuilder
-        .AddMeter("OpenTelemetry.Demo.Cart.Meter")
+        .AddMeter("OpenTelemetry.Demo.Cart")
         .AddProcessInstrumentation()
         .AddRuntimeInstrumentation()
         .AddAspNetCoreInstrumentation()

diff --git a/src/cartservice/src/cartstore/ValkeyCartStore.cs b/src/cartservice/src/cartstore/ValkeyCartStore.cs
@@ -25,8 +25,8 @@ public class ValkeyCartStore : ICartStore
     private readonly byte[] _emptyCartBytes;
     private readonly string _connectionString;
 
-    private static readonly ActivitySource CartActivitySource = new("OpenTelemetry.Demo.Cart.Source");
-    private static readonly Meter CartMeter = new Meter("OpenTelemetry.Demo.Cart.Meter");
+    private static readonly ActivitySource CartActivitySource = new("OpenTelemetry.Demo.Cart");
+    private static readonly Meter CartMeter = new Meter("OpenTelemetry.Demo.Cart");
     private static readonly Histogram<long> addItemHistogram =
         CartMeter.CreateHistogram<long>
         (