Skip to content

Commit

Permalink
fix(k8s): make 'latest' tag parsing logic work correctly
Browse files Browse the repository at this point in the history
The most recent dev versions of the scylla operator started looking like
the following: 'v1.12.0-alpha.1-78-ge5a1c9b-latest'
Before it was like following: 'v1.12.0-alpha.0-144-g60f7824'

We were depending on the number of the '-' symbols and it now leads to
the filtering out of the new kind of chart versions.
So, fix it by properly checking helm chart versions.
  • Loading branch information
vponomaryov authored and fruch committed Jan 24, 2024
1 parent 6f48e10 commit 722f51a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdcm/cluster_k8s/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ def get_latest_chart_version(self, local_chart_path: str) -> str:
# in each 'minor' family.
current_newest_version, current_newest_version_str = None, ''
for version_object in all_versions:
if version_object["version"].count('-') not in (0, 3):
if version_object["version"].count('-') == 1:
continue
if ComparableScyllaOperatorVersion(version_object["version"]) > (
current_newest_version or '0.0.0'):
Expand Down

0 comments on commit 722f51a

Please sign in to comment.