Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to prevent deletion #13

Open
LJJS opened this issue Nov 5, 2020 · 3 comments
Open

Add feature to prevent deletion #13

LJJS opened this issue Nov 5, 2020 · 3 comments
Labels

Comments

@LJJS
Copy link

LJJS commented Nov 5, 2020

It would be handy to be able to lock the possibility to delete bills. So the data can't be changed without notice and there would be a full history of all interactions.

So to "revert" (delete) a bill, it would be just necessary to add a new bill with the exact invert of the selected one which should be reverted.

@julien-nc
Copy link
Owner

Thanks for the suggestion. This could be an option reserved for those with project admin access (not Nextcloud admins). I might add it after next release. To be continued.

@julien-nc julien-nc added the todo label Nov 8, 2020
julien-nc pushed a commit that referenced this issue Dec 20, 2020
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc added testing and removed todo labels Dec 20, 2020
@julien-nc
Copy link
Owner

Hey. It's available in latest nightly build. it would be nice if you could try it before next release.

There's a new checkbox in project sidebar's Settings tab to disable bill deletion. This option is only visible to users having admin permissions in the project.

@LJJS
Copy link
Author

LJJS commented Apr 5, 2021

Hey,
sorry for my late response. I somehow missed the notification.

Anyway, thank you so much for this feature.
It works just as imagined.

I have a few improvements suggestions:

  • Next to disable the deletion, it should be possible to lock a bill. After all the values are entered the bill will be locked so no changes of "What", "How much", "When", "Repeat" are possible. This changes are now still possible, so when setting the spent money to 0 it would be the same as a deletion.
    My suggestions would be, when the checkbox to disable bill deletion is checked, the user must press a button to save the bill and after that no changes are possible.

  • To allow the users to correct an false bill, it would be neat to have a button next to the wrong bill, which creates an inverse new bill. This added new bill shows all the users that an other bill was "deleted"/negated.

  • I don't know if it fits here or in MoneyBuster. When deleting a bill within the app, the message {"message":"Forbidden"} appears and the project sync is then broken and no further actions are possible except to remove the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants