write the Access-Control-Allow-Methods header if Router.HandleOPTIONS… #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very useful PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is true
This is a required CORS preflight header to allow the browser to perform AJAX for any of the other available methods for a given URL.
Rather than set HandleOPTIONS = false, and be forced to create separate OPTIONS handlers for my (numerous!) routes it's simpler/less work to let the router do it when it's setting the Allow header. My preference would be to not maintain a separate fork of the router for such a simple change.
Are you opposed to merging this into mainline?
Regards,
Patrick