fix maxParams bug #261
Merged
fix maxParams bug #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienschmidt
force-pushed
the
fix_maxparams_bug
branch
from
cf40920
to
066b6d4
Compare
|
Good catch, thanks! |
similark
pushed a commit
to similarweb/httprouter
that referenced
this pull request
May 9, 2023
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is only one route "/cmd/*fildpath", the structure of the tree is:
01:00 /cmd[1] false 1
01:01 [1] true 3
01:01 /*filepath[0] 0x124f970 false 3
The maxParams of the "/cmd" node is 0, but it should be 1