Only auto-start clojure-lsp in valid projects

When the `"when-workspace-opened-use-workspace-root"` setting is enabled
the clojure-lsp is started in _all_ workspace roots open instead of only
valid clojure project roots.

This commit reworks this behaviour to first check if the workspace root
is a valid Clojure project before attempting to auto-start the lsp
server.

Addresses BetterThanTomorrow#2041

src/extension.ts

@@ -80,7 +80,7 @@ async function activate(context: vscode.ExtensionContext) {
       testRunner.onTestTree(testController, tree);
     },
   });
-  clientProvider.init();
+  await clientProvider.init();
 
   lsp.registerGlobally(clientProvider);
 

src/lsp/provider.ts

@@ -1,4 +1,5 @@
 import * as vscode_lsp from 'vscode-languageclient/node';
+import * as project_utils from '../project-root';
 import * as vscode from 'vscode';
 import * as path from 'node:path';
 
@@ -143,7 +144,7 @@ export const createClientProvider = (params: CreateClientProviderParams) => {
   return {
     getClientForDocumentUri: (uri: vscode.Uri) => api.getClientForDocumentUri(clients, uri),
 
-    init: () => {
+    init: async () => {
       status_bar_item.show();
 
       if (vscode.window.activeTextEditor?.document.languageId === 'clojure') {
@@ -163,8 +164,15 @@ export const createClientProvider = (params: CreateClientProviderParams) => {
 
       switch (config.getAutoStartBehaviour()) {
         case config.AutoStartBehaviour.WorkspaceOpened: {
-          vscode.workspace.workspaceFolders.forEach((folder) => {
-            void provision_queue.push(folder.uri).catch((err) => console.error(err));
+          const roots = await project_utils.findProjectRootsWithReasons();
+          const workspace_folders = roots
+            .filter((root) => {
+              return root.valid_project && root.workspace_root;
+            })
+            .map((root) => root.uri);
+
+          workspace_folders.forEach((root) => {
+            void provision_queue.push(root).catch((err) => console.error(err));
           });
           break;
         }
@@ -199,9 +207,13 @@ export const createClientProvider = (params: CreateClientProviderParams) => {
           });
 
           if (config.getAutoStartBehaviour() === config.AutoStartBehaviour.WorkspaceOpened) {
-            event.added.forEach((folder) => {
-              void provision_queue.push(folder.uri).catch((err) => console.error(err));
-            });
+            void Promise.allSettled(
+              event.added.map(async (folder) => {
+                if (await project_utils.isValidClojureProject(folder.uri)) {
+                  void provision_queue.push(folder.uri).catch((err) => console.error(err));
+                }
+              })
+            );
           }
         })
       );

src/project-root.ts

@@ -86,6 +86,14 @@ export function excludePattern(moreExcludes: string[] = []) {
   return `**/{${[...moreExcludes, ...config.getConfig().projectRootsSearchExclude].join(',')}}/**`;
 }
 
+export async function isValidClojureProject(uri: vscode.Uri) {
+  return findProjectRootsWithReasons().then((roots) => {
+    return !!roots.find((root) => {
+      return uri.path === root.uri.path && root.valid_project;
+    });
+  });
+}
+
 function findMatchingParent(
   from: vscode.Uri,
   uris: vscode.Uri[],