Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication between dbml-parser and core #25

Closed
julioz opened this issue May 19, 2020 · 0 comments · Fixed by #27
Closed

Remove duplication between dbml-parser and core #25

julioz opened this issue May 19, 2020 · 0 comments · Fixed by #27

Comments

@julioz
Copy link
Owner

julioz commented May 19, 2020 •
edited
Loading

Pull out DBML model classes into shared module that Room translator can depend on, in that way we can rely on a single definition of the DBML models across all modules of the codebase.

Potentially rename :core to something specific to Room, since we want to allow for other input formats (see for example: #19).
This was referenced May 19, 2020
Merged
Merged
julioz added a commit that referenced this issue May 24, 2020
@julioz
Remove Room-specific model classes (#27)
720f80d 
Fixes #25 

Replaces the hard dependency on Room's modeling for the rendering logic and instead use `:dbml`'s module models as source for output rendering as `String`.

That way, we allow for other input sources (besides Room) while FloorPlan still outputs the DBML string representation.

This PR removes the `:core` module, and instead introduces `:dbml-render`, responsible for the conversion DBML -> String.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Room-specific model classes julioz/FloorPlan
1 participant
@julioz