-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Uno_jll to MINLPTests #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 1 1
Lines 84 84
=======================================
Hits 83 83
Misses 1 1 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
odow
commented
Oct 17, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
odow
commented
Oct 18, 2024
odow
commented
Oct 18, 2024
odow
commented
Oct 18, 2024
odow
commented
Oct 18, 2024
This comment was marked as resolved.
This comment was marked as resolved.
odow
commented
Oct 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
odow
commented
Oct 20, 2024
odow
commented
Oct 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
odow
commented
Oct 24, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Oct 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
odow
commented
Oct 27, 2024
Okay. I think we're pretty much there. There are still a few upstream issues, but these are mainly:
|
odow
commented
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs JuliaRegistries/General#117429 (comment)
But there are bunch of other issues:
@cvanaret: is the options file compulsory? This doesn't align with other AMPL solvers.
So then I did
But it's not enough to have an empty file, you need the complete set of options
and now this fails because the default action is to pass
-AMPL
:AmplNLWriter.jl/src/AmplNLWriter.jl
Line 74 in 69220af