-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wrapper generator to Clang.jl master #119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
===========================================
+ Coverage 55.66% 89.78% +34.12%
===========================================
Files 3 2 -1
Lines 636 333 -303
===========================================
- Hits 354 299 -55
+ Misses 282 34 -248
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! As a side note: why'd you pick Clp? Just for test cases for Clang? Or are you interested in optimization? I ask because there are a lot of other solvers in |
I update them because we are preparing a new Clang.jl release as in JuliaInterop/Clang.jl#299. Also this is part of my OSPP project. Lines 1 to 10 in 9a0b9d1
|
Very cool. I'll comment in the other issue, but don't let the |
On next release, Clang.jl will release a new generator format, this updates the wrapper generator to the new format, and makes uses of JLL packages instead of manually copying headers. Compared using https://github.com/melonedo/WrapperComparator, the new wrapper will be identical to the old one.
cc @Gnimuc.