Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent use of whitespace #240

Closed
omus opened this issue Oct 31, 2018 · 1 comment
Closed

Inconsistent use of whitespace #240

omus opened this issue Oct 31, 2018 · 1 comment

Comments

@omus
Copy link
Contributor

omus commented Oct 31, 2018

2-space and 4-space indenting seem to be used inconsistently. FWIW I prefer consistent 4-spacing.

Originally posted by @chriscoey in #239 (comment)
@ararslan
Copy link
Contributor

There doesn't appear to be a general style guide for JuliaOpt, but JuMP has its own, which says 4 spaces. It's pretty much the de facto standard anyway.

ararslan added a commit that referenced this issue Nov 7, 2018
@ararslan
Normalize indentation to 4 spaces
51b4233 
The package currently uses a mixture of indentation, including 2- and
4-space indents, as well as tab characters. This normalizes everything
to 4-space indents only, which is the standard Julia style, and is
what's recommended in the JuMP style guide.

Fixes #240.
@ararslan ararslan mentioned this issue Nov 7, 2018
Merged
ararslan added a commit that referenced this issue Nov 7, 2018
@ararslan
Normalize indentation to 4 spaces
16fbd45 
The package currently uses a mixture of indentation, including 2- and
4-space indents, as well as tab characters. This normalizes everything
to 4-space indents only, which is the standard Julia style, and is
what's recommended in the JuMP style guide.

Fixes #240.
ararslan added a commit that referenced this issue Nov 8, 2018
@ararslan
Normalize indentation to 4 spaces
1ea8851 
The package currently uses a mixture of indentation, including 2- and
4-space indents, as well as tab characters. This normalizes everything
to 4-space indents only, which is the standard Julia style, and is
what's recommended in the JuMP style guide.

Fixes #240.
ararslan added a commit that referenced this issue Nov 8, 2018
@ararslan
Normalize indentation to 4 spaces
70863e5 
The package currently uses a mixture of indentation, including 2- and
4-space indents, as well as tab characters. This normalizes everything
to 4-space indents only, which is the standard Julia style, and is
what's recommended in the JuMP style guide.

Fixes #240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omus @ararslan