use testsets #222
Merged
use testsets #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlubin
reviewed
Jan 27, 2018
test/test_socp.jl
Outdated
| @fact evaluate(vecnorm(x, 2)) --> roughly(norm(vec(A), 2), TOL); | ||
| @fact evaluate(vecnorm(x, 7)) --> roughly(norm(vec(A), 7), TOL); | ||
| @fact evaluate(vecnorm(x, Inf)) --> roughly(norm(vec(A), Inf), TOL); | ||
| $(Expr(:toplevel, :(@test isapprox(evaluate(norm(x)), norm(A), atol=TOL)))) |
There was a problem hiding this comment.
Why does this need to be wrapped in toplevel? Shouldn't @test isapprox(evaluate(norm(x)), norm(A), atol=TOL) work?
There was a problem hiding this comment.
Good catch. This was not intended! The reason is that this was done by a hacky script that proceeds line by line and parse("foo;") (note the ;) gives Expr(:toplevel, :foo).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
FactCheckby testsets.