Add infeasibility certificate for variable bounds #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These new tests are not in MOI to avoid breaking changes? |
|
Until we get some conventions that generalize across solvers, I thought it would be better to keep the tests within this repo. It we have some tests that multiple solvers pass, we can add them to MOI. |
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 85.46% 86.42% +0.95%
==========================================
Files 8 8
Lines 1390 1392 +2
==========================================
+ Hits 1188 1203 +15
+ Misses 202 189 -13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows jump-dev/Gurobi.jl#363
This also changes how we compute infeasibility certificates. We now directly solve the dual and obtain an unbounded ray, instead of simply aggregating violated constraints. The previous behavior generated a valid infeasibility certificate, but it didn't match the Farkas-type results in the tests.