Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precompilation directives #173

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Add precompilation directives #173

merged 2 commits into from
Mar 5, 2021

Conversation

odow
Copy link
Member

@odow odow commented Feb 19, 2021

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #173 (d7de33e) into master (1d1fc09) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   84.57%   84.57%   -0.01%     
==========================================
  Files           8        9       +1     
  Lines        1504     1536      +32     
==========================================
+ Hits         1272     1299      +27     
- Misses        232      237       +5     
Impacted Files Coverage Δ
src/GLPK.jl 100.00% <ø> (ø)
src/precompile.jl 100.00% <100.00%> (ø)
src/MOI_wrapper/MOI_copy.jl 95.91% <0.00%> (-2.73%) ⬇️
src/MOI_wrapper/MOI_wrapper.jl 91.71% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d1fc09...d7de33e. Read the comment docs.

@odow
Copy link
Member Author

odow commented Mar 5, 2021

I've updated this to a manually curated list of functions, as suggested by @timholy: jump-dev/JuMP.jl#2484 (comment).

I think this has a lot of benefits of the raw SnoopCompile approach, because we ensure wider coverage of key paths, and we won't have this list continually updating.

@odow odow changed the title WIP: Add precompilation directives Add precompilation directives Mar 5, 2021
@odow odow merged commit 5569e07 into master Mar 5, 2021
@odow odow deleted the od/precompile branch March 5, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant