Fix bug modifying a constraint after deletion #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Aug 15, 2023
| @@ -3497,6 +3499,7 @@ function MOI.modify( | |||
| ::MOI.ObjectiveFunction{MOI.ScalarAffineFunction{Float64}}, | |||
| chg::MOI.ScalarCoefficientChange{Float64}, | |||
| ) | |||
| _update_if_necessary(model) | |||
There was a problem hiding this comment.
These ones didn't seem to be necessary for the test, but I added just in case. I don't understand the internal details.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
==========================================
+ Coverage 90.86% 90.87% +0.01%
==========================================
Files 5 5
Lines 2418 2422 +4
==========================================
+ Hits 2197 2201 +4
Misses 221 221
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #514
The lazy update thing is really annoying. Most of the time it caches modifications in a queue, but it looks like deletions are handled separately to modifications.