Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extension] Implement set_objective_function instead of set_objective #2247

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 7, 2020

It implement set_objective_sense so implementing set_objective was not appropriate as there is a fallback to set_objective_sense and set_objective_function.

@blegat blegat added this to the 0.21.3 milestone Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #2247 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2247      +/-   ##
==========================================
- Coverage   91.30%   91.22%   -0.08%     
==========================================
  Files          42       42              
  Lines        4186     4253      +67     
==========================================
+ Hits         3822     3880      +58     
- Misses        364      373       +9     
Impacted Files Coverage Δ
src/objective.jl 91.66% <100.00%> (ø)
src/Containers/SparseAxisArray.jl 77.88% <0.00%> (-0.69%) ⬇️
src/Containers/DenseAxisArray.jl 87.50% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df1796...4e0e887. Read the comment docs.

@blegat blegat merged commit 01e464f into master Jun 17, 2020
@odow odow deleted the bl/set_obj_fun branch June 22, 2020 02:55
odow added a commit that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant