Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster deletion of bounds in fix #2521

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Faster deletion of bounds in fix #2521

merged 1 commit into from
Mar 9, 2021

Conversation

blegat
Copy link
Member

@blegat blegat commented Mar 9, 2021

delete_upper_bound(variable) was going back to a case where we need to access the backend and get an allocation for type unstability.

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #2521 (9d27af8) into master (54c8b58) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2521   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files          43       43           
  Lines        4696     4696           
=======================================
  Hits         4341     4341           
  Misses        355      355           
Impacted Files Coverage Δ
src/variables.jl 98.47% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c8b58...64a5f13. Read the comment docs.

@odow odow merged commit 994d16b into master Mar 9, 2021
@odow odow deleted the bl/del_bound branch March 9, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants