Make some moi_xxx functions private #2548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2548 +/- ##
==========================================
- Coverage 93.53% 92.94% -0.60%
==========================================
Files 43 44 +1
Lines 5401 5456 +55
==========================================
+ Hits 5052 5071 +19
- Misses 349 385 +36
Continue to review full report at Codecov.
|
blegat
approved these changes
Apr 6, 2021
|
This is a breaking change, we should wait for the next 0.xx release: |
Closed
|
Closing for now because #2610 is changing some things. We can revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we have a policy on how we un-export functions that were mistakenly exported? (i.e., do they need deprecation warnings?)
Here we clearly want people to use
mode,add_constraint, andbridge_constraints, not theirmoi_xxxequivalents.Before 1.0, we should go through all exported functions and check whether we want to export them.