Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Make moi_backend a concrete type and remove MANUAL mode #2756

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

odow
Copy link
Member

@odow odow commented Oct 15, 2021

An alternative to #2610

There's a few things going on in this PR because I wanted to see them all together. If we want to do this, we can either merge as-is or break it down into separate PRs.

  • Make moi_backend a concrete type
  • Rename bridge_constraints to add_bridges
  • Encourage add_bridges = false for latency improvements
  • Remove MANUAL mode

Closes #2610
Closes #2520
Closes #1627

@odow odow added this to the 1.0 milestone Oct 15, 2021
@odow odow added the breaking label Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #2756 (c393126) into master (6b48409) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2756      +/-   ##
==========================================
+ Coverage   94.18%   94.20%   +0.02%     
==========================================
  Files          43       43              
  Lines        5520     5525       +5     
==========================================
+ Hits         5199     5205       +6     
+ Misses        321      320       -1     
Impacted Files Coverage Δ
src/JuMP.jl 85.49% <100.00%> (+0.50%) ⬆️
src/copy.jl 95.31% <100.00%> (-0.08%) ⬇️
src/optimizer_interface.jl 77.35% <100.00%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b48409...c393126. Read the comment docs.

docs/src/manual/models.md Outdated Show resolved Hide resolved
@odow odow force-pushed the od/concrete-backend branch from a4a999e to d7454c3 Compare October 19, 2021 21:09
docs/src/manual/models.md Outdated Show resolved Hide resolved
@odow odow merged commit 8beda88 into master Oct 20, 2021
@odow odow deleted the od/concrete-backend branch October 20, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Bridges in Manual mode with solver not supporting default_copy_to
2 participants