Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MA.add_mul for GenericNonlinearExpr arguments #3488

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Sep 6, 2023

This should let us merge jump-dev/MutableArithmetics.jl#225 without breakage.

The default fallback in MA is annoying for types that have different representations of a + b and b + a:
jump-dev/MutableArithmetics.jl#225 (comment)

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.09% ⚠️

Comparison is base (37d5b70) 98.09% compared to head (0f42f5c) 98.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3488      +/-   ##
==========================================
- Coverage   98.09%   98.00%   -0.09%     
==========================================
  Files          37       37              
  Lines        5520     5525       +5     
==========================================
  Hits         5415     5415              
- Misses        105      110       +5     
Files Changed Coverage Δ
src/nlp_expr.jl 99.04% <75.00%> (-0.24%) ⬇️
src/aff_expr.jl 96.96% <100.00%> (-0.36%) ⬇️
src/mutable_arithmetics.jl 92.17% <100.00%> (+0.28%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit a157126 into master Sep 6, 2023
9 of 11 checks passed
@odow odow deleted the od/fix-add-mul branch September 6, 2023 02:56
@odow odow mentioned this pull request Sep 6, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant