Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complex variables of custom coefficient type #3691

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Fix complex variables of custom coefficient type #3691

merged 6 commits into from
Feb 29, 2024

Conversation

blegat
Copy link
Member

@blegat blegat commented Feb 29, 2024

  • Tests

Closes #3689

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (1195695) to head (47ebc24).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3691   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files          43       43           
  Lines        5698     5698           
=======================================
  Hits         5605     5605           
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow changed the title Complex variables of custom coefficient type Fix complex variables of custom coefficient type Feb 29, 2024
test/test_complex.jl Outdated Show resolved Hide resolved
test/test_complex.jl Outdated Show resolved Hide resolved
test/test_complex.jl Outdated Show resolved Hide resolved
@odow odow merged commit d031be9 into master Feb 29, 2024
11 checks passed
@odow odow deleted the bl/complexf32 branch February 29, 2024 20:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Coefficients of complex variables created with a GenericModel are always Float64
2 participants