Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issue in _canonical_quadratic_reduction #296

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

odow
Copy link
Member

@odow odow commented Jul 22, 2024

@Robbybp can you try this branch?

@odow odow changed the title Fix performace issue in _canonical_quadratic_reduction Fix performance issue in _canonical_quadratic_reduction Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (38d473f) to head (6765ee6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   84.61%   85.00%   +0.38%     
==========================================
  Files           3        3              
  Lines        1001     1000       -1     
==========================================
+ Hits          847      850       +3     
+ Misses        154      150       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Jul 22, 2024

Merging because I'm pretty happy that this is an improvement. I'll leave #286 open until @Robbybp can re-test on master.

@odow odow merged commit 26e9477 into master Jul 22, 2024
6 checks passed
@odow odow deleted the od/knitro-speed branch July 22, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant