Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalidation of println #1328

Merged
merged 1 commit into from
May 10, 2021
Merged

Fix invalidation of println #1328

merged 1 commit into from
May 10, 2021

Conversation

odow
Copy link
Member

@odow odow commented May 10, 2021

This definition invalidated some pretty basic print functionality:

inserting println(io::IO, card::MathOptInterface.FileFormats.MPS.Card) in MathOptInterface.FileFormats.MPS at /Users/oscar/.julia/dev/MathOptInterface/src/FileFormats/MPS/MPS.jl:114 invalidated:
   backedges: 1: superseding println(xs...) in Base at coreio.jl:4 with MethodInstance for println(::Any, ::Any) (1 children)
              2: superseding println(io::IO, xs...) in Base at strings/io.jl:73 with MethodInstance for println(::IO, ::Any) (7 children)
   27 mt_cache

@odow odow merged commit 550f585 into master May 10, 2021
@odow odow deleted the od/fix-invalidation branch May 10, 2021 07:56
@odow odow mentioned this pull request May 10, 2021
Closed
@blegat blegat added this to the v0.10 milestone May 22, 2021
blegat pushed a commit that referenced this pull request May 22, 2021
@odow @blegat
Fix invalidation of println (#1328)
f119138
blegat pushed a commit that referenced this pull request May 22, 2021
@odow @blegat
Fix invalidation of println (#1328)
e286865
blegat pushed a commit that referenced this pull request May 23, 2021
@odow @blegat
Fix invalidation of println (#1328)
5c8fe1c
@blegat blegat modified the milestones: v0.10, v0.9.22 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport 0.9 Type: Performance
Milestone
v0.9.22
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @blegat