[breaking] move JSONSchema to a test dependency #1333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big cause of method invalidation in JuMP is HTTP (jump-dev/JuMP.jl#2273). One option is to fix them in HTTP, but that requires modifications to Base Julia (JuliaWeb/HTTP.jl#712).
The better question is: why do we even have HTTP as a dependency? Turns out it is a transitive dependency of JSONSchema, which may need to access schemas from the web. We only use JSONSchema to validate MOF files, and then not even by default.
And if we move JSONSchema to a test and doc dependency, we save 0.4 seconds on
using
, and 1000 method invalidations!Before
After