Add test for a feasibility problem #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
- Coverage 59.17% 58.96% -0.22%
==========================================
Files 23 23
Lines 3559 3599 +40
==========================================
+ Hits 2106 2122 +16
- Misses 1453 1477 +24
Continue to review full report at Codecov.
|
blegat
reviewed
Feb 19, 2018
src/Test/contlinear.jl
Outdated
| function linear13test(model::MOI.ModelLike, config::TestConfig) | ||
| atol = config.atol | ||
| rtol = config.rtol | ||
| # find x |
blegat
reviewed
Feb 19, 2018
|
|
||
| c1sol = 2 * xsol + 3 * ysol | ||
| @test c1sol >= 1 || isapprox(c1sol, 1.0, atol=atol, rtol=rtol) | ||
| @test xsol - ysol ≈ 0 atol=atol rtol=rtol |
There was a problem hiding this comment.
We should check ConstraintPrimal too
|
Thanks, I've addressed the comments. |
blegat
approved these changes
Feb 20, 2018
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.