Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SOCRBridge and disable SOCtoPSDBridge #751

Merged
merged 3 commits into from
Aug 30, 2019
Merged

Add SOCRBridge and disable SOCtoPSDBridge #751

merged 3 commits into from
Aug 30, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented May 27, 2019

Closes #637

@blegat blegat added breaking Submodule: Bridges About the Bridges submodule labels May 27, 2019
frapac
frapac reviewed May 27, 2019
View reviewed changes
src/Bridges/socr_bridge.jl Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented May 28, 2019 •
edited
Loading

Codecov Report

Merging #751 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   94.93%   94.87%   -0.06%     
==========================================
  Files          72       73       +1     
  Lines        7912     7929      +17     
==========================================
+ Hits         7511     7523      +12     
- Misses        401      406       +5
Impacted Files Coverage Δ
src/Bridges/Constraint/soc_to_psd.jl 91.37% <ø> (-8.63%) ⬇️
src/Bridges/Constraint/rsoc.jl 100% <100%> (ø) ⬆️
src/Bridges/Constraint/socr.jl 100% <100%> (ø)
src/Bridges/Constraint/Constraint.jl 96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217305f...9cebb2a. Read the comment docs.

@blegat blegat mentioned this pull request May 28, 2019
Closed
@blegat blegat removed the breaking label May 31, 2019
@blegat
Copy link
Member Author

blegat commented May 31, 2019

Currently blocked by JuliaLang/julia#32167

@blegat blegat mentioned this pull request Jun 13, 2019
Merged
@blegat blegat force-pushed the bl/socr branch 2 times, most recently from 6585286 to 78e45fe Compare August 12, 2019 20:07
@chriscoey
Copy link
Contributor

So RSOC and SOCR are different bridges. It's not clear from the naming which one does which. Are there slightly more verbose names we could use? If @mlubin is ok with the naming then don't worry.

@mlubin
Copy link
Member

mlubin commented Aug 13, 2019

Neither RSOC nor SOCR are standard abbreviations so we should try to avoid using either. RotatedToSOC and SOCToRotated are alternatives.

@blegat blegat mentioned this pull request Aug 29, 2019
Closed
@blegat
Copy link
Member Author

blegat commented Aug 29, 2019

I moved the naming to a separate issue as it would be breaking:
#860
Any other objection ? The failure is now resolved thanks to #834

@blegat blegat merged commit 74ec8f2 into master Aug 30, 2019
@blegat blegat deleted the bl/socr branch October 10, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frapac frapac frapac left review comments

@mlubin mlubin mlubin approved these changes

Assignees
No one assigned
Labels
Submodule: Bridges About the Bridges submodule
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SOCtoRSOCBridge and disable SOCtoPSDBridge
5 participants
@blegat @codecov-io @chriscoey @mlubin @frapac