Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some Float64 assumptions #878

Merged
merged 1 commit into from
Sep 15, 2019
Merged

Conversation

ericphanson
Copy link
Contributor

Fixes #876.

I also changed convert(T, √2) to √T(2) in a few places to improve precision when T is a BigFloat (calculate the square-root in the BigFloat domain).

@ericphanson
Copy link
Contributor Author

Note: I didn't add any tests, because I think the tests solution is to finish #841 and then test those tests with BigFloat problems. But I can say from local testing that these changes let SDPA-GMP pass Convex.jl's tests with the SOCP problems that otherwise fail.

@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #878 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
+ Coverage   95.01%   95.01%   +<.01%     
==========================================
  Files          80       80              
  Lines        8284     8286       +2     
==========================================
+ Hits         7871     7873       +2     
  Misses        413      413
Impacted Files Coverage Δ
src/Bridges/Constraint/rsoc.jl 100% <100%> (ø) ⬆️
src/Bridges/Variable/soc_to_rsoc.jl 100% <100%> (ø) ⬆️
src/Bridges/Constraint/slack.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345c03b...4e6275f. Read the comment docs.

@blegat blegat merged commit 10bbddb into jump-dev:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Explicit float64 assumption in /Bridges/Constraint/rsoc.jl
4 participants