Prep for v1.0 release and drop support for pre Julia 1.6 versions #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 84.38% 83.94% -0.44%
==========================================
Files 20 20
Lines 1857 1850 -7
==========================================
- Hits 1567 1553 -14
- Misses 290 297 +7
Continue to review full report at Codecov.
|
|
@blegat thoughts on dropping < 1.6 support? |
|
Merging, but I'll wait for @blegat to confirm before tagging. He's been traveling the last few weeks |
|
No objection, let's drop it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense at this point to drop support for Julia <1.6 in all v1.0 releases in JuMP-dev.