Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BigFloat for Julia v1.12 #307

Merged
merged 11 commits into from
Oct 13, 2024
+86 −143
Merged

Fix BigFloat for Julia v1.12 #307

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
be48c0b
Fix mutable_copy(::BigFloat) in Julia v1.12
odow Oct 10, 2024
aa0fa69
Update src/implementations/BigFloat.jl
odow Oct 10, 2024
7f2159c
Update
odow Oct 10, 2024
b261d01
Update src/implementations/BigFloat.jl
odow Oct 10, 2024
ec3f42b
Simplify test/bigfloat_dot.jl
odow Oct 10, 2024
5bb93e1
Update
odow Oct 10, 2024
18befd9
Update
odow Oct 10, 2024
879898a
Update
odow Oct 12, 2024
74b3982
Update
odow Oct 13, 2024
5254fb5
Update
odow Oct 13, 2024
ce60f92
update
odow Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/implementations/BigFloat.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,18 @@

mutability(::Type{BigFloat}) = IsMutable()

# Copied from `deepcopy_internal` implementation in Julia:
# https://github.com/JuliaLang/julia/blob/7d41d1eb610cad490cbaece8887f9bbd2a775021/base/mpfr.jl#L1041-L1050
function mutable_copy(x::BigFloat)
d = x._d
d′ = GC.@preserve d unsafe_string(pointer(d), sizeof(d)) # creates a definitely-new String
return Base.MPFR._BigFloat(x.prec, x.sign, x.exp, d′)
@static if VERSION >= v"1.12"
odow marked this conversation as resolved.
Show resolved Hide resolved
function mutable_copy(x::BigFloat)
return Base.MPFR._BigFloat(copy(getfield(x, :d)))
end
else
# Copied from `deepcopy_internal` implementation in Julia:
# https://github.com/JuliaLang/julia/blob/7d41d1eb610cad490cbaece8887f9bbd2a775021/base/mpfr.jl#L1041-L1050
function mutable_copy(x::BigFloat)
d = x._d
d′ = GC.@preserve d unsafe_string(pointer(d), sizeof(d)) # creates a definitely-new String
return Base.MPFR._BigFloat(x.prec, x.sign, x.exp, d′)
end
end

const _MPFRRoundingMode = Base.MPFR.MPFRRoundingMode
Expand Down
Loading