Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [compat] in Project.toml #284

Closed
wants to merge 4 commits into from
Closed

Fix [compat] in Project.toml #284

wants to merge 4 commits into from

Conversation

odow
Copy link
Member

@odow odow commented Oct 24, 2023

No description provided.

Project.toml Outdated Show resolved Hide resolved
@odow
Copy link
Member Author

odow commented Oct 24, 2023

cc @vchuravy I'm getting LoadError: empty intersection between SparseArrays@0.0.0 and project compatibility 1.6.0-1.

It looks like it is happening because we Pkg.add stuff to the environment during test:

SCS.jl/test/runtests.jl

Lines 15 to 16 in 1a5cb7d

import Pkg
Pkg.add(Pkg.PackageSpec(name = "MKL_jll", version = "2022"))

Any ideas?

@odow
Copy link
Member Author

odow commented Oct 24, 2023

Closing as won't-fix (for now).

There is a bug in Pkg.jl that doesn't let compat bounds for stdlibs if Pkg operations take place in the tests.

It will be fixed with a new release of 1.6.X (and 1.9.X or 1.10.0), so we can re-visit once that happens.

The downside is that any new releases may need a manual merge to General.

@odow odow closed this Oct 24, 2023
@odow odow deleted the odow-patch-1 branch October 24, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant