Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDPAFamily to tests #126

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Add SDPAFamily to tests #126

merged 1 commit into from
Oct 11, 2019

Conversation

ericphanson
Copy link
Contributor

Running the tests, one gets a couple of warnings due to ericphanson/SDPAFamily.jl#22.

I excluded three testsets which errored due to not returning the precise status required, and two that gave the error

 ArgumentError: Bridge of type `MathOptInterface.Bridges.Constraint.VectorFunctionizeBridge{Float64,SumOfSquares.SOSPolynomialSet{SemialgebraicSets.FullSpace,DynamicPolynomials.Monomial{true},DynamicPolynomials.MonomialVector{true},SumOfSquares.Certificate.Remainder{SumOfSquares.NonnegPolyInnerCone{SumOfSquares.DiagonallyDominantConeTriangle},PolyJuMP.MonomialBasis,Tuple{}}}}` does not support accessing the attribute `SumOfSquares.GramMatrixAttribute(1)`.

but I'm not sure if that's a problem with SDPAFamily or not. The rest for the linear and SDP tests seem to work though.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 77.4% when pulling 3f524f2 on ericphanson:master into 0ac73d2 on JuliaOpt:master.

@blegat
Copy link
Member

blegat commented Oct 11, 2019

Thanks for the addition. The solver tests currently don't work on SumOfSquares#master, I'm working on it, so it's expected that some tests fails. We can now add SDPAFamily in https://github.com/sums-of-squares/sos/blob/master/index.md

@codecov-io
Copy link

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   79.38%   79.38%           
=======================================
  Files          27       27           
  Lines         655      655           
=======================================
  Hits          520      520           
  Misses        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac73d2...3f524f2. Read the comment docs.

@blegat blegat merged commit e907adb into jump-dev:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants