Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use dynamic images on bridge pages #1557

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

feat: use dynamic images on bridge pages #1557

wants to merge 17 commits into from

Conversation

dennyscode
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jumper-exchange ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 11:04am

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

Playwright test results

passed  16 passed
skipped  3 skipped

Details

stats  19 tests across 3 suites
duration  3 minutes, 24 seconds
commit  d44b770

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to Supefest
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color

@tcheee
Copy link
Contributor

tcheee commented Dec 3, 2024

image
image should be below text no?

@tcheee
Copy link
Contributor

tcheee commented Dec 3, 2024

image
it broke the list

tcheee
tcheee requested changes Dec 3, 2024
View reviewed changes
src/app/ui/bridge/BridgePage.style.ts Outdated Show resolved Hide resolved
oktapodia
oktapodia requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@oktapodia oktapodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

src/app/ui/bridge/StepDetail.tsx Outdated Show resolved Hide resolved
src/app/ui/bridge/StepsExplainer.tsx Outdated Show resolved Hide resolved
src/app/ui/bridge/StepsExplainer.tsx Outdated Show resolved Hide resolved
src/app/ui/bridge/StepsExplainer.tsx Outdated Show resolved Hide resolved
src/app/ui/bridge/StepsExplainer.tsx Outdated Show resolved Hide resolved
src/app/ui/bridge/utils.tsx Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Test results (4/4)

passed  4 passed
flaky  1 flaky

Details

stats  5 tests across 2 suites
duration  5 minutes, 15 seconds
commit  82f64d1

Flaky tests

chromium › swapActions.spec.ts › On chain swaps › Check USDC to WETH swap pair on ETH chain

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Test results (3/4)

failed  2 failed
passed  3 passed

Details

stats  5 tests across 2 suites
duration  8 minutes, 42 seconds
commit  fb886ee

Failed tests

chromium › swapActions.spec.ts › On chain swaps › Check ETH to USDTUSDT swap pair on ETH chain
chromium › swapActions.spec.ts › On chain swaps › Check USDT to DAI swap pair on ETH chain

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Test results (2/4)

passed  4 passed
skipped  1 skipped

Details

stats  5 tests across 1 suite
duration  31.2 seconds
commit  82f64d1

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Test results (1/4)

passed  5 passed
skipped  1 skipped

Details

stats  6 tests across 2 suites
duration  1 minute, 1 second
commit  82f64d1

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission

oktapodia
oktapodia requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@oktapodia oktapodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more commments

src/app/ui/bridge/InformationCard.style.ts Outdated Show resolved Hide resolved
src/app/ui/bridge/StepDetail.style.ts Outdated Show resolved Hide resolved
@dennyscode dennyscode changed the title feat: integrate dynamic images on SEO pages feat: integrate dynamic images on bridge pages Dec 17, 2024
@dennyscode dennyscode changed the title feat: integrate dynamic images on bridge pages feat: use dynamic images on bridge pages Dec 17, 2024
@tcheee
Copy link
Contributor

tcheee commented Dec 18, 2024

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcheee tcheee tcheee approved these changes

@oktapodia oktapodia Awaiting requested review from oktapodia

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dennyscode @tcheee @oktapodia