Fixed: Fixed the issue that When switching different node export same file #4597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaiJiangJie
reviewed
Jan 13, 2025
| * 那如果首次点击的树节点，那么此时 url 就会被确定，后续点击的树节点，那么 url 就不会 | ||
| * 改变了 | ||
| */ | ||
| return Object.assign({}, this.exportOptions, { url: this.tableUrl }) | ||
| } | ||
| }, | ||
| methods: { |
There was a problem hiding this comment.
The code is looking good overall, it appears there are no known defects or issues at the moment. However, given that we don't know where and when it was last updated, I would recommend updating to ensure there are no bugs introduced over time.
Optimization Suggestions:
- Use
constinstead ofletfor variables that can be modified later, reducing memory usage (though this has minimal effect here). - Inlining
Object.assign()could improve performance if called often in a similar context, but in this case, it's unlikely as it seems to perform well already. - Ensure all references to
_tCurrentTreeId_have proper types set (number) - If you decide to add more properties to the
dataObj, consider wrapping them into separate constants outside their current scope for clarity - Consider using ES6 modules instead of CommonJS modules if the project will eventually move towards Node v8 or beyond
Note: As JavaScript is dynamically typed and its type inference might not catch everything, always do unit tests including edge cases.
|
ZhaoJiSen
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Fixed the issue that When switching different node export same file