Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ios project path selector changed #224

Merged
merged 3 commits into from
Jun 11, 2023

Conversation

dopplerDistortion
Copy link
Contributor

Info.plist selection have a problem of selecting wrong folder if you try to change an app name that has third party extension with Info.plist file.

For example if react-native-onesignal installed in your app. It requires you to create an extension that named OneSignalNotificationServiceExtension and if your app name initial is something after letter O in alphabetical order, lets call it RnDiffApp, following selector in utils.js returns the OneSignalNotificationServiceExtension path.

const iosInfoPlistFullPath = globbySync(normalizePath(path.join(APP_PATH, iosPlist)))[0];

Expected result should be RnDiffApp path. So remaining scripts will change CFBundleDisplayName in RnDiffApp/Info.plist.

@dopplerDistortion dopplerDistortion marked this pull request as draft April 14, 2023 15:56
@dopplerDistortion dopplerDistortion marked this pull request as ready for review April 14, 2023 16:10
@junedomingo junedomingo merged commit 814ebf9 into junedomingo:master Jun 11, 2023
@junedomingo
Copy link
Owner

@dopplerDistortion Thank you for this!🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants