Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Kotlin templates #290

Merged

Conversation

szymonrybczak
Copy link
Contributor

Description

Fixes #289

In React Native 0.73, whole Android template was migrated to Kotlin, read here for more details: https://reactnative.dev/blog/2023/12/06/0.73-debugging-improvements-stable-symlinks#kotlin-template-on-android

Test plan

  1. Create new app with npx react-native@latest init
  2. Run node /path/to/this/tool "newname" --bundleId com.new.name
  3. Run yarn android, app should correctly build and run.

@szymonrybczak
Copy link
Contributor Author

cc @junedomingo mind having a look and releasing new version as it is adding support for 0.73? 🙏

@junedomingo junedomingo merged commit 165fb9e into junedomingo:master Jan 20, 2024
2 of 3 checks passed
@junedomingo
Copy link
Owner

Thank you @szymonrybczak !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Native 0.73 MainApplication.kt and MainActivity.kt do not accept the rename
2 participants