Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Alacritty preview in ANSI Format #3822

Closed
wants to merge 1 commit into from
Closed

Add support for Alacritty preview in ANSI Format #3822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bin/fzf-preview.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,12 @@ if [[ $KITTY_WINDOW_ID ]]; then

# 2. Use chafa with Sixel output
elif command -v chafa > /dev/null; then
chafa -f sixel -s "$dim" "$file"
# Alacritty doesn't support sixels
if [[ $ALACRITTY_WINDOW_ID ]]; then
chafa --colors 256 -s "$dim" "$file"
else
chafa -f sixel -s "$dim" "$file"
fi
Comment on lines +60 to +65
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The man page of chafa states that it auto-detects the right format.

OUTPUT ENCODING
       -f, --format format
           Set output format; one of [iterm, kitty, sixels, symbols]. The
           default is iterm, kitty or sixels if the connected terminal
           supports one of these, falling back to symbols ("ANSI art")
           otherwise.

Which means we can just drop -f sixel instead?

Suggested change
# Alacritty doesn't support sixels
if [[ $ALACRITTY_WINDOW_ID ]]; then
chafa --colors 256 -s "$dim" "$file"
else
chafa -f sixel -s "$dim" "$file"
fi
chafa -s "$dim" "$file"

Hmm, no, chafa fails to detect it's on iTerm2 and doesn't render image nicely on it. The issue is fixed on master, but no releases yet.

hpjansson/chafa#196

I don't use alacritty, but I believe it's capable of showing more than 256 colors. So why don't we just drop --colors 256?

If left unspecified, an optimal default will be chosen based on the current environment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give this a test ... on vacation for a week but have some time today to verify

Copy link
Author

@jeeftor jeeftor Jun 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wez / Alacritty

image

I can confirm this ... on iterm2 it shows up as ansi/

Iterm2

image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have the new chafa version with the fix, I think we can just drop -f sixel as suggested above.

# Add a new line character so that fzf can display multiple images in the preview window
echo

Expand Down