Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode vim-plug logo and use correct logo version in README #1267

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

rnwst
Copy link
Contributor

@rnwst rnwst commented Mar 2, 2024

The vim-plug logo in the README wasn't visible in dark mode due to black lettering on a dark background. This PR fixes this by adding an color-inverted version of the logo, and using the right version in the README depending on the result of the prefers-color-scheme CSS media query.

Copy link
Owner

@junegunn junegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's not rename plug.png to keep the image URL accessible.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rnwst
Copy link
Contributor Author

rnwst commented Mar 6, 2024

Ready to be merged?

@junegunn junegunn merged commit 3049761 into junegunn:master Mar 6, 2024
1 check passed
@junegunn
Copy link
Owner

junegunn commented Mar 6, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants