Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pressing 'q' to abort the running tasks, then 'R' to retry #1289

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

junegunn
Copy link
Owner

@junegunn junegunn commented Jul 8, 2024

If you press 'q' while PlugInstall or PlugUpdate is in progress, the current version of vim-plug immediately closes its window and aborts all the running processes.

This commit enhances the 'q' map so that it doesn't close the window, but instead displays aborted tasks so that the user can press 'R' to retry aborted/skipped tasks.

Fix #1285

/cc @yous

image

If you press 'q' while `PlugInstall` or `PlugUpdate` is in progress,
the current version of vim-plug immediately closes its window and aborts
all the running processes.

This commit enhances the 'q' map so that it doesn't close the window,
but instead displays aborted tasks so that the user can press 'R' to
retry aborted/skipped tasks.

Fix #1285
@junegunn junegunn self-assigned this Jul 8, 2024
@junegunn junegunn changed the title Allow pressing 'q' to abort the process; and 'R' to retry Allow pressing 'q' to abort the process; then 'R' to retry Jul 8, 2024
@yous yous mentioned this pull request Jul 8, 2024
11 tasks
@yous
Copy link
Contributor

yous commented Jul 8, 2024

Thanks for the swift update. This will mitigate various scenarios with connection problems, including mine.

@junegunn junegunn changed the title Allow pressing 'q' to abort the process; then 'R' to retry Allow pressing 'q' to abort the running tasks, then 'R' to retry Jul 9, 2024
@junegunn junegunn merged commit d80f495 into master Jul 9, 2024
1 check passed
@junegunn junegunn deleted the q-abort branch July 9, 2024 11:09
@junegunn
Copy link
Owner Author

junegunn commented Jul 9, 2024

Thanks for the review. Let me know if it doesn't work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

g:plug_timeout is not respected for SSL connection timeout
2 participants