Wrap assumption violations in ErrorCollector #1395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcooney
force-pushed
the
ErrorCollectorWrapAssumptionFailure
branch
from
d9e0589 to
0371aba
Compare
marcphilipp
approved these changes
Nov 30, 2016
| if (error instanceof AssumptionViolatedException) { | ||
| AssertionError e = new AssertionError(error.getMessage()); | ||
| e.initCause(error); | ||
| error = e; |
There was a problem hiding this comment.
Minor thing: I'm generally not happy with reassigning method parameters.
There was a problem hiding this comment.
Fixed (though for a method this small, I find the previous version readable and slightly better than the duplication in the updated code)
kcooney
force-pushed
the
ErrorCollectorWrapAssumptionFailure
branch
from
d5e7b04 to
867f186
Compare
|
Note there are two commits, and I want to keep them separate. I will be happy to do the merge. If this is approved I'll also merge #1371 |
marcphilipp
approved these changes
Dec 3, 2016
|
Merged. |
|
added to the release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addError() and checkSucceeds() now wrap assumption violations.