Recommend order attribute for TestWatcher and tidy up tests #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stefanbirkner
commented
Feb 10, 2018
•
stefanbirkner
commented
- Recommend to always set order for TestWatcher .
- Make it easier to understand TestWatcher's behavior based on the tests.
- Improve expressiveness of the test.
- Add missing tests.
stefanbirkner
force-pushed
the
test-watcher
branch
6 times, most recently
from
9cacd0b to
715a445
Compare
stefanbirkner
changed the title
stefanbirkner
force-pushed
the
test-watcher
branch
3 times, most recently
from
022cc8e to
bf2cc6f
Compare
marcphilipp
approved these changes
Mar 7, 2018
- Make it easier to understand TestWatcher's behavior based on the tests. - Improve expressiveness of the test. - Add missing tests.
TestWatcher may see failed tests as successful and vice versa if it is not the outermost rule and another rule changes the result of a test (e.g. ErrorCollector or ExpectedException). Fixes junit-team#1436.
stefanbirkner
force-pushed
the
test-watcher
branch
from
bf2cc6f to
cf13399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.