Only deprecate ExpectedException.none() #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of deprecating the whole class, now only the factory method is deprecated and points to `assertThrows()`. This will make it easier to temporarily suppress the exception for codebases that use it extensively by adding an intermediate factory method of their own. Resolves #1609.
|
LGTM 👍 |
stefanbirkner
approved these changes
Oct 21, 2019
marcphilipp
deleted the
issues/1609-only-deprecate-expectedexception-factory-method
branch
|
Thanks. |
|
@marcphilipp Are you updating the release notes or should I do this part? |
|
@stefanbirkner If you could that would be great, thanks! 👍 |
|
Done. |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of deprecating the whole class, now only the factory method is
deprecated and points to
assertThrows(). This will make it easier totemporarily suppress the exception for codebases that use it
extensively by adding an intermediate factory method of their own.
Resolves #1609.